Add support for logout from OAuth provider #6935
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6935 +/- ##
==========================================
- Coverage 81.57% 81.51% -0.06%
==========================================
Files 323 323
Lines 47509 47550 +41
==========================================
+ Hits 38754 38762 +8
- Misses 8755 8788 +33 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now we never logged the user out of the OAuth provider we simply cleared the cookies. This is "usually" the desirable behavior since often the OAuth provider is part of a larger SSO system and you don't want to log someone out of Google/GitHub/Gitlab/Azure/Okta when you're simply wanting to log out of the app. Here we make it possible to log the user out of Okta and make the logout endpoint configurable for the
GenericLoginHandler.